Repository navigation
Conversation
…e lint matrix The requirement was a bare `black`, so each CI Python resolved a different release (23.3.0 on 3.7 ... 26.10.1 on 3.10-3.12) and the newest normalizes androidtv/exceptions.py's module docstring value, which the repo's own formatting cannot absorb without a literal change. 23.3.0 is the newest release that still supports the maintained Python 3.7 leg and it leaves package, tests, and setup.py clean as authored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADB commands can be discarded while a screenshot or another valid operation holds the connection lock for more than three seconds. The transport can still be healthy:
_acquireraisesLockNotAcquiredExceptionbefore the queued command gets a chance to run. Home Assistant handles that exception by skipping the command.Wait for the asynchronous connection lock by default. Explicit acquisition deadlines still work, and the ADB transport keeps its existing network timeouts. Cancelling a waiting command leaves the active command’s lock intact.
The regression test holds a real
asyncio.Lockbeyond the previous three-second limit, then checks that the queued shell command completes after release. It fails withLockNotAcquiredExceptionon the original code. A second test covers cancellation and subsequent connection reuse.Validation:
python -m unittest discover -s tests -t .ran 236 tests successfully (one skipped). Black checks both changed files with the project settings; Flake8 checks the changed source file.